This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Testing cleanups for PR 2731 - #2779
Merged
Merged
Conversation
No code changes. Only automated indent fix. Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Contributor
Author
|
@TheNavigat Mind taking a look? |
See: travis-ci/travis-ci#3239 Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Contributor
There was a problem hiding this comment.
This line is unreachable. You probably need to remove sys.exit(1) at line 68.
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Contributor
Author
|
Good call! Anything else? |
Contributor
|
Nope, LGTM. Good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny nits for PR #2731